Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Intermittent failure for screenshot tests due to window sizes #2411

Open
samtygier-stfc opened this issue Nov 21, 2024 · 1 comment
Open

Comments

@samtygier-stfc
Copy link
Collaborator

Summary

We are currently seeing a large number of failures of the screenshot tests because the Spectrum window is mostly rendering at a different size than it was last week.

There are no obvious code or package changes that should cause this.

Widget sizing in Qt is complicated. Things may change size as various bits of a window are initialised or data is loaded. But the tests ought to do things in a consistent way, and give a consistent result.

Steps To Reproduce

Happening to most current PRs

Expected Behaviour

Windows render at a consistent size.

Current Behaviour

Spectrum window is rendering at a different size than it was last week.

Context

Current main

@samtygier-stfc
Copy link
Collaborator Author

samtygier-stfc commented Nov 21, 2024

Git bisect suggests it could have been:

Bisecting: 0 revisions left to test after this (roughly 0 steps)
[cda8ff90f61d96c45bcba4805c207e9a0b2b205d] The main window is not the parent of SpectrumProjectionWidget

Change is in #2356

It was noted in the comments, but the baseline branch did not get merged on applitools when the PR was merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant