Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convergence plot optimisation #2412

Open
samtygier-stfc opened this issue Nov 21, 2024 · 0 comments
Open

Convergence plot optimisation #2412

samtygier-stfc opened this issue Nov 21, 2024 · 0 comments

Comments

@samtygier-stfc
Copy link
Collaborator

Some optimsations for the the convergence plot in the reconstruction progress window

Desired Behaviour

  • Only create the PlotWidget the first time set_progress_plot() is called
  • Only call update_progress_plot() when there is something new to plot (the loss is only calculated every 10th iteration). (maybe if the last element in iterations is the same as the current step, or something like that).

Current Behaviour

PlotWidget is always created, even when it is not used

Plot gets updates on every iteration, even if nothing has changed

#2399 (review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant