feat(connection): add option to unset ISM and hook #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aroralanuk
commented
Dec 6, 2024
aroralanuk
commented
- fixes Previously set hooks or ISMs cannot be unset, so contracts can't opt back into using the default hook / ISM #140
- added unit tests for corresponding code in connection package
yorhodes
approved these changes
Dec 17, 2024
Comment on lines
+63
to
+71
| let removed_ism = get_ism(deps.storage)? | ||
| .map(|addr| addr.to_string()) | ||
| .unwrap_or_else(|| "none".to_string()); | ||
|
|
||
| ISM.remove(deps.storage); | ||
|
|
||
| Ok(event_to_resp( | ||
| new_event("unset_ism").add_attribute("ism", removed_ism), | ||
| )) |
There was a problem hiding this comment.
imo we dont really need to know what ISM was removed in the event
Suggested change
| let removed_ism = get_ism(deps.storage)? | |
| .map(|addr| addr.to_string()) | |
| .unwrap_or_else(|| "none".to_string()); | |
| ISM.remove(deps.storage); | |
| Ok(event_to_resp( | |
| new_event("unset_ism").add_attribute("ism", removed_ism), | |
| )) | |
| ISM.remove(deps.storage); | |
| Ok(event_to_resp( | |
| new_event("unset_ism") | |
| )) |
Comment on lines
+86
to
+96
| None => { | ||
| let removed_hook = get_hook(deps.storage)? | ||
| .map(|addr| addr.to_string()) | ||
| .unwrap_or_else(|| "none".to_string()); | ||
|
|
||
| HOOK.remove(deps.storage); | ||
|
|
||
| Ok(event_to_resp( | ||
| new_event("unset_hook").add_attribute("hook", removed_hook), | ||
| )) | ||
| } |
There was a problem hiding this comment.
Suggested change
| None => { | |
| let removed_hook = get_hook(deps.storage)? | |
| .map(|addr| addr.to_string()) | |
| .unwrap_or_else(|| "none".to_string()); | |
| HOOK.remove(deps.storage); | |
| Ok(event_to_resp( | |
| new_event("unset_hook").add_attribute("hook", removed_hook), | |
| )) | |
| } | |
| None => { | |
| HOOK.remove(deps.storage); | |
| Ok(event_to_resp( | |
| new_event("unset_hook") | |
| )) | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.