Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add autofix where possible #15

Open
maratori opened this issue Nov 10, 2019 · 0 comments
Open

Add autofix where possible #15

maratori opened this issue Nov 10, 2019 · 0 comments

Comments

@maratori
Copy link
Owner

maratori commented Nov 10, 2019 •
edited
Loading

Need to suggest fixes.
Fix is a code refactoring, so:

  1. It must not break code
  2. It should not be suggested, if non-breaking change is not possible

For example it's not possible to suggest fix, if test uses private entities from original package.

It isn't enough just to replace pkg -> pkg_test.
At least need to change imports as well.

Also it's better to avoid dot import if possible.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support autofixing
1 participant
@maratori