Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support autofixing #31

Closed
wants to merge 1 commit into from
Closed

feat: support autofixing #31

wants to merge 1 commit into from

Conversation

G-Rath
Copy link
Contributor

@G-Rath G-Rath commented Jun 23, 2022

Resolves #15

@codeclimate
Copy link

codeclimate bot commented Jun 23, 2022

Code Climate has analyzed commit b73f59d and detected 0 issues on this pull request.

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jun 23, 2022

Codecov Report

Merging #31 (b73f59d) into main (fa49f6b) will not change coverage.
The diff coverage is 100%.

@@         Coverage Diff         @@
##           main    #31   +/-   ##
===================================
  Coverage   100%   100%           
===================================
  Files         1      1           
  Lines        36     51   +15     
===================================
+ Hits         36     51   +15
Impacted Files Coverage Δ
pkg/testpackage/testpackage.go 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa49f6b...b73f59d. Read the comment docs.

maratori
maratori requested changes Jun 23, 2022
View reviewed changes
Copy link
Owner

@maratori maratori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@G-Rath thanks for contribution.

It's my bad, I didn't add description to the issue #15.
Now I've closed this gap.

Unfortunately, current autofix breaks user's code.
Solution will be more complicated.

@G-Rath
Copy link
Contributor Author

G-Rath commented Jun 23, 2022 •
edited
Loading

Ah fair enough - I was hoping there was a way to provide suggestions vs fixes, similar to what ESLint supports to say "we can start the fix for you but there will be manual work".

I'll close this PR as while I'm interested, I don't think I'll have the time right now to dive into what I expect will be a pretty complex slice of work 🙂

@G-Rath G-Rath closed this Jun 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maratori maratori maratori requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add autofix where possible
2 participants
@G-Rath @maratori