C11 #7
Closed
C11 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@frobnitzem thanks for your time and effort here! 🎉 I see you're still making commits. Would you mind switching to draft until you're done? Or, do you want me to review mid-stream? I may not be able to get to until early next week. |
|
I'm starting to think a lot of the changes (C11 and removing operation-counts) run counter to the original project's goals. I'm canceling this PR pending more discussion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Several updates to the coding style of heat.C, args.C, and util.C. Closes #5 (leaves printf-s as-is).
On second thought, a lot of this could have been done by putting the arg-reader and the state in a single "State" class, and making most of the code into methods of that class.