GFM ignores comments

[ivanjaros]

When I enable GFM I still see comments being rendered, despite them being part of the spec:

https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#hiding-content-with-comments

[UziTech]

This demo seems to follow the spec.

[ivanjaros]

There is some replacing taking place

marked/src/rules.ts

Line 41 in 6062657

const _comment = /<!--(?:-?>|[\s\S]*?(?:-->|$))/;

but am not sure what it actually does. In my case(i only use lexer), I end up with html tag and i have to check for <!-- preffix. There is no "comment" type or no transformation into empty "space" or any other tag or complete removal of it. Technically it is html tag but I would expect GFM to parse it and remove it altogether because GFM can render html tags but ignore html comment and that is not what i am observing. I guess it's one of those lexer vs renderer behavioural differences yet again.

[UziTech]

The Lexer still creates a comment token like it should but when rendered it doesn't display anything because it is rendered like an html comment

[ivanjaros]

[UziTech]

If you check the source of this comment you will see the html comment is still there the browser just doesn't render it.

[UziTech]

Marked follows this GFM spec https://github.github.com/gfm/#example-152

[ivanjaros]

because it is treated like html. it should not be rendered at all. i render html as escaped text to discourage users from using it and this caused the text to be rendered for me which simply surprised me because i expected marked to simply ignore it altogether. i have mitigated it by checking for said prefix so it is fine.