New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve handle of bootstrapping on a node with different MIP store during versioning #4794

Open

3 tasks

Leo-Besancon opened this issue Dec 18, 2024 · 1 comment

Collaborator

Leo-Besancon commented Dec 18, 2024 •

edited

Loading

As mentioned in #4772, we want to decrease the reliance on MassaLabs bootstrap nodes.

One case we may need to handle better is described by the following scenario:

We have a Massa Improvement Proposal that is in the "Started" state (this means nodes with this MIP are actively voting on it)
We bootstrap on a node without this MIP
As a result, we do not have the vote counts of this MIP, and we will desync with nodes that have a different vote count as us

We need to :

Make a Unit test for this behavior
Choose how to handle this (some ideas: refusing bootstrap on a node on a previous version if the MIP is started, sync the vote count afterward (e.g. with trusted MassaLabs nodes that check the final state hash + sends the MIP store), or in an other way
Implement it

Contributor

bilboquet commented Dec 18, 2024

with trusted MassaLabs nodes
I think it goes against decentralization, which is the reason we have introduced #4772

Maybe the bootstrap process should be reworked to propagate any vote about any MIP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment