Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

importorskip statements should be used in the test suite #441

Open
Andrew-S-Rosen opened this issue Sep 28, 2023 · 1 comment
Open

importorskip statements should be used in the test suite #441

Andrew-S-Rosen opened this issue Sep 28, 2023 · 1 comment

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Sep 28, 2023 •
edited
Loading

If fireworks or matplotlib (potentially others like maggma, moto, ...) are not installed, the test suite fails. It would be better to use a importorskip marker (preferable) or to update the dev optional dependencies to be the full suite of dependencies needed to run the tests. Alternatively, the contributing instructions should say to install the strict dependencies.
@Andrew-S-Rosen Andrew-S-Rosen changed the title BUG: Test suite fails if fireworks or matplotlib are not installed BUG: importorskip statements should be used in the test suite Sep 28, 2023
@utf
Copy link
Member

utf commented Sep 28, 2023

I would be happy to accept a PR that skips tests if the packages aren't installed.

@Andrew-S-Rosen Andrew-S-Rosen changed the title BUG: importorskip statements should be used in the test suite importorskip statements should be used in the test suite Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@utf @Andrew-S-Rosen