Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug risk: paramiko-related deprecation warning #987

Open
1 of 3 tasks
Andrew-S-Rosen opened this issue Aug 10, 2024 · 5 comments
Open
1 of 3 tasks

Bug risk: paramiko-related deprecation warning #987

Andrew-S-Rosen opened this issue Aug 10, 2024 · 5 comments
Labels

Comments

@Andrew-S-Rosen
Copy link
Member

Andrew-S-Rosen commented Aug 10, 2024

Code snippet

from maggma.stores import MemoryStore

returns

C:\Users\asros\miniconda\envs\test\Lib\site-packages\paramiko\pkey.py:100: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
  "cipher": algorithms.TripleDES,
C:\Users\asros\miniconda\envs\test\Lib\site-packages\paramiko\transport.py:259: CryptographyDeprecationWarning: TripleDES has been moved to cryptography.hazmat.decrepit.ciphers.algorithms.TripleDES and will be removed from this module in 48.0.0.
  "class": algorithms.TripleDES,

I remain a bit unsure where this is coming from. TripleDes is not directly called in maggma, so this may not be a "maggma problem" per se, but it would be worth finding the source so we can: a) inform the maintainer; b) make sure maggma doesn't break in the future.

Version

0.69.1

Which OS?

  • MacOS
  • Windows
  • Linux

Log output

No response

@rkingsbury
Copy link
Collaborator

thanks for reporting @Andrew-S-Rosen

@rkingsbury
Copy link
Collaborator

Note: this appears to be resolved upon updating to paramiko==3.5. I'll try to bump the dependencies in maggma soon.

@rkingsbury
Copy link
Collaborator

As a further note to self, paramiko is required by the sshtunnel package for tunnel functionality. the sshtunnel package itself has not been updated since 2021 and lists itself in "Alpha" status. This poses some concerns. Maybe it's worth investigating an alternative way to access paramiko's SSHTunnel capabilities in maggma.

@rkingsbury
Copy link
Collaborator

As a further note to self, paramiko is required by the sshtunnel package for tunnel functionality. the sshtunnel package itself has not been updated since 2021 and lists itself in "Alpha" status. This poses some concerns. Maybe it's worth investigating an alternative way to access paramiko's SSHTunnel capabilities in maggma.

@jmmshn are you aware of any alternative ways of accessing ssh tunnels via python? This seems like a common use case so I was surprised to see sshtunnel not being maintained.

@jmmshn
Copy link
Contributor

jmmshn commented Dec 6, 2024

@jmmshn are you aware of any alternative ways of accessing ssh tunnels via python?

Not aware of any directly replacements. However I think if and when things break there are two things we can do:

  1. Users can port-forward to get their entire pipeline working.
  2. We can re-implement a paramiko-only solution.
  3. We can fix ssh-tunnel, no reason to assume they would not be responsive.

So IMO, due to 1. the risk is not catastrophic?? We can leave the original reference from the sshtunnel repo:

https://github.com/paramiko/paramiko/blob/main/demos/forward.py

As alternative on what to do if things break.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants