Webhooks don't always resolve username

[apollo13]

Creating tags and issues yields the following:

It seems as if

mattermost-plugin-gitlab/server/webhook/tag.go

Line 43 in 442334d

senderGitlabUsername := w.gitlabRetreiver.GetUsernameByID(event.UserID)

goes awry. couldn't it just use UserName directly?

[apollo13]

GetUsernameByID goes through

mattermost-plugin-gitlab/server/plugin.go

Lines 208 to 214 in 442334d

	func (p *Plugin) getGitlabIDToUsernameMapping(gitlabUserID string) string {
	gitlabUsername, err := p.API.KVGet(gitlabUserID + GitlabIDUsernameKey)
	if err != nil {
	p.API.LogError("can't get user id by login", "err", err.DetailedError)
	}
	return string(gitlabUsername)
	}

and seems to ask mattermost itself for an id mapping?

[apollo13]

Interesting, after executing /gitlab settings notifications on the username is resolved properly. Nevertheless I do not think this is the expected behavior and this KV-mapping shouldn't be used?

[apollo13]

Currently blocked by xanzy/go-gitlab#1183