-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gremsy Vio with SDK 2.1.5 'Unknown parameter to get option' and 'not found.' when setting GB_MODE which depends on SETTING_TARGET #196
Comments
It's probably best to debug this after the big camera PR has been merged with v3. |
Looks like it is loading the full XML, but when it gets to |
Could this be a bug inside of the camera software? |
Don't think so - QGC works. I'm having it print out all of the parameters that the
where it stops at "SP" but the actual XML file has a couple more things under "SP",
I'm printing out the XML contents that the tinyxml2 library gets line by line,
and modified the loop to print out each param name encountered,
|
Oh but that would have been easier for me 😬 |
Got it, it's because there are two parameters in the XML that have default values that don't match one of the listed options and the SDK logic bails out as a result,
The offending parameters are,
Looks like QGC just skips over them and continues processing the rest of the config, that's why QGC works... |
Well, to be fair, that's pretty wrong on their side. I'll see if I can skip over them instead but it just masks the problem and means you can't use the settings, so there are pros and cons to this approach. |
@rayw-dronesense any chance you can update the camera? It looks like this is fixed with: |
Thanks for the suggestions. It doesn't seem like I can update the camera unfortunately as it came packaged with the aircraft in my possession. However, it does look like I can intercept the config downloaded and make the change to the two parameters at least. That said, for the long run, do we want to match QGC behavior in the SDK, or whichever one is 'correct'? |
Can you tell your aircraft manufacturer to please update this? That way the ball starts rolling, hopefully. In terms of behavior, I suppose we can be pragmatic and change it, and just accept broken stuff. Feel free to make a pull request, thanks. |
Environment
Camera definition contents:
https://github.com/Gremsy/Vio-Camera-Definition/releases/download/v2.0.3/vio_camera_f1_def.xml
Problem
When using
camera.setSetting
onGB_MODE
this happens,Calling
camera.setSetting
withSETTING_TARGET
setting it to "1" works. It is only trying to setGB_MODE
this error occurs.The text was updated successfully, but these errors were encountered: