Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSL Picker should use HSLColor in internal usage. #63

Open
DioboKN opened this issue Nov 16, 2021 · 4 comments
Open

HSL Picker should use HSLColor in internal usage. #63

DioboKN opened this issue Nov 16, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@DioboKN
Copy link

DioboKN commented Nov 16, 2021

No description provided.

@mchome
Copy link
Owner

mchome commented Nov 16, 2021

Post your code, tell me what was expected and what was wrong.

@DioboKN
Copy link
Author

DioboKN commented Nov 16, 2021

When I didn't slide to black and white, the lightness of the color was correct, but when I slid to black, it changed to black lightness.

ColorPickerSlider(
TrackType.lightness,
currentHsvColor,
onColorChanging,
displayThumbColor: true,
),

@mchome
Copy link
Owner

mchome commented Nov 16, 2021

Oh, based on the hsv converting, the saturation will reset to 0. This is expected behavier since it use HSVColor in internal.

@mchome mchome added the enhancement New feature or request label Nov 16, 2021
@mchome mchome changed the title When I use "TrackType.lightness" in "ColorPickerSlider" and slide it to the two ends, it can only select the color between black and white. HSL Picker should use HSLColor in internal usage. Nov 16, 2021
@DioboKN
Copy link
Author

DioboKN commented Nov 16, 2021

Ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mchome @DioboKN