Add shortcut to toggle audio recording and REST API #1072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
louis030195
reviewed
Dec 30, 2024
| device_type: payload.device_type.unwrap_or(DeviceType::Input), | ||
| }; | ||
|
|
||
| state.audio_devices_control.push((device.clone(), DeviceControl { is_running: true, is_paused: false })); |
There was a problem hiding this comment.
does this work? i implemented audio_devices_control back then but not sure it's even working anymore
louis030195
reviewed
Dec 30, 2024
| await new Promise((resolve) => setTimeout(resolve, 1000)); | ||
| relaunch(); | ||
| }) | ||
| ]); | ||
|
|
||
| listen('shortcut-start-audio', async () => { | ||
| toast({ |
There was a problem hiding this comment.
this seems wrong
why are you not using the rest API to stop/start audio device?
should not interrupt the vision recording
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r_videoloop.mp4
a_videoloop.mp4
/closes #1065
/claim #1065