Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed Conflict with Swifts Task by renaming Task to MTask #454

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed Conflict with Swifts Task by renaming Task to MTask #454

wants to merge 1 commit into from

Conversation

MiaKoring
Copy link

Pull Request

Related issue

Fixes #453

What does this PR do?

  • renames Task to MTask to fix the related issue

PR checklist

Please check if your PR fulfills the following requirements:

  • [ X] Does this PR fix an existing issue, or have you listed the changes applied in the PR description (and why they are needed)?
  • [X ] Have you read the contributing guidelines?
  • [X ] Have you made sure that the title is accurate and descriptive of the changes?

Thank you so much for contributing to Meilisearch!

@MiaKoring
Fixed Conflict with swifts Task
6899d0e 
renamed Meilisearch's Task to MTask
@Sherlouk
Copy link
Collaborator

Sherlouk commented Dec 9, 2024

I do agree that we aught to rename this as it's fraught with conflicts given its common name.

Users of the library can apply namespaces to avoid this in the short-term (MeiliSearch.Task vs Swift.Task), but this isn't ideal.

This is a notable breaking change though so might need to hold off on releasing this until we have a couple other changes lined up to minimise medium-term impact.

@MiaKoring
Copy link
Author

I totally understand and agree and thank you so much for reviewing it that fast :)

@curquiza curquiza added the breaking-change The related changes are breaking for the users label Dec 9, 2024
Sherlouk
Sherlouk approved these changes Dec 10, 2024
View reviewed changes
Copy link
Collaborator

@Sherlouk Sherlouk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignore the fact CI has failed, it's been having a mare for a while. I'll look to fix that in a separate PR.

Clem, this can be merged, but we won't release until a few things are ready to go.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sherlouk Sherlouk Sherlouk approved these changes

Assignees
No one assigned
Labels
breaking-change The related changes are breaking for the users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Meilisearch’s Task inferres with Swift’s Task.
3 participants
@MiaKoring @Sherlouk @curquiza