Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repo permission levels for Meltano Engineers #58

Open
MeltyBot opened this issue Feb 28, 2022 · 1 comment
Open

Repo permission levels for Meltano Engineers #58

MeltyBot opened this issue Feb 28, 2022 · 1 comment

Comments

@MeltyBot
Copy link

MeltyBot commented Feb 28, 2022

Migrated from GitLab: https://gitlab.com/meltano/handbook/-/issues/64

Originally created by @aaronsteers on 2022-02-28 19:42:38


Following from other conversations on #63 and !108, I wanted to open this issue to discuss what the proper permission level is for Gitlab projects for our team.

Permission Levels

  1. Project/Group Developer
    • Today every engineer inherits this at the group level.
  2. Project/Group Maintainer
    • In theory, this is really only needed when setting up a new repo, in order to setup the project as described in !108.
  3. Project/Group Owner
    • Similar to Maintainer, but at a higher level. (Not sure what the important distinctions are here.)
  4. Repo Codeowner
    • For projects which enable it, this is the designated primary/secondary approvers we set for each code path via the CODEOWNERS file.
    • Note: this is basically orthogonal with the permission levels 1-3, above.

Consideration

  1. Everyone should have sufficient permissions to do their job.
  2. Certain permissions that don't need to be changed often can be maintained or initialized by a small group of responsible persons.
  3. We don't have great auditing on project level settings, and we want to avoid a case where a setting is modified but it's impossible to tell who changed it or when it was changed. (A small group of responsible parties (2-3) is preferred, for this reason.)
  4. If everyone in the Engineering team does require elevated (Maintainer and/or Owner) permissions, we should document the reasons for that and update our new user onboarding processes to reflect this.
@MeltyBot
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant