Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a .DEB package #4

Open
mendhak opened this issue May 16, 2012 · 4 comments
Open

Create a .DEB package #4

mendhak opened this issue May 16, 2012 · 4 comments

Comments

@mendhak
Copy link
Owner

mendhak commented May 16, 2012

A .deb package that takes care of installing and copying the files, setting permissions.

Check to see if uninstallation takes care of removing all files.

@fossfreedom
Copy link

if this helps closing this one - I've done just this for your plugin in my PPA:

https://launchpad.net/~fossfreedom/+archive/rhythmbox-plugins/+files/rhythmbox-plugin-tray-icon_0.2-1ubuntu2_all.deb

BTW - there seems to be a couple of pull requests in the upstream palfrey project - is this something you may be interested in pulling into your version?

@mendhak
Copy link
Owner Author

mendhak commented Feb 20, 2013

Oops, I forgot to respond here. Yes, and it's done now. I've added the tooltip feature. I also had to replace the icon so that they are standalone and separate. I had to do this for a Fedora issue, I think.

@clefebvre
Copy link
Collaborator

Hi @mendhak,

I added the commits we worked on lately.

I can do the following changes too, just let me know if you want them:

  • Add the debian/ packaging (we've done this already, it's all ready)
  • Remove the zip file (no need for it at all, people can use git clone via https instead of wget and cp -R instead of unzip)
  • Update the README.md to reflect latest changes and DE support (for instance now that the plugin is enabled by default, you don't need to go and enable it anymore).

@mendhak
Copy link
Owner Author

mendhak commented Nov 29, 2016

Hi all those changes sound great. Yes removing the zip file is fine, I agree it's not needed. Please feel free to shape this how you want, you are more active.

I did think of pulling your changes in myself to save you some time, but I don't know how to merge from a different git 'tree'. I could do it manually but then your name won't be in commits!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants