Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ZAP wrapper shall use proxy parameter settings for user, realm and password #3657

Open
de-jcup opened this issue Nov 27, 2024 · 0 comments
Open

Comments

@de-jcup
Copy link
Member

de-jcup commented Nov 27, 2024

Situation

With #3611 the parameters "proxyUser", "proxyPassword" and "proxyRealm" where introduced:

@Parameter(names = { "--proxyRealm" }, description = "Specify a proxy realm. You can also set the environment variable "
+ EnvironmentVariableConstants.PROXY_REALM_ENV_VARIABLE_NAME + ", instead of using this parameter.", required = false)
private String proxyRealm;
public String getProxyRealm() {
return proxyRealm;
}
@Parameter(names = { "--proxyUsername" }, description = "Specify a proxy username. You can also set the environment variable "
+ EnvironmentVariableConstants.PROXY_USERNAME_ENV_VARIABLE_NAME + ", instead of using this parameter.", required = false)
private String proxyUsername;
public String getProxyUsername() {
return proxyUsername;
}
@Parameter(names = { "--proxyPassword" }, description = "Specify a proxy password. You can also set the environment variable "
+ EnvironmentVariableConstants.PROXY_PASSWORD_ENV_VARIABLE_NAME + ", instead of using this parameter.", required = false)
private String proxyPassword;
public String getProxyPassword() {
return proxyPassword;

But currently we do not use this inside

if (proxyInformation != null) {
LOG.info("Adding proxy to firefox browser options.");
// TODO 2024-11-25 jan: add additional proxy data like credentials
String proxyString = "%s:%s".formatted(proxyInformation.getHost(), proxyInformation.getPort());
Proxy proxy = new Proxy();
proxy.setHttpProxy(proxyString);
proxy.setSslProxy(proxyString);
options.setProxy(proxy);
}

Wanted

The proxy setup inside proxyinformation (it comes from parameters and/or environment entries)
shall be used for the communication.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant