Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DeBridge Parser #24

Closed
wants to merge 3 commits into from
Closed

DeBridge Parser #24

wants to merge 3 commits into from

Conversation

takshakmudgal
Copy link
Contributor

Description

Parser for DeBridge

Fixes #23

Type of change

  • Updated dependencies.
  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Is this a Breaking change? (fix or feature that would cause existing functionality to not work as expected)
  • Did this get a semantic version bump?
  • Does this PR include any Tests for the changes made or already existing codebase?
  • Documentation updates.
  • Configuration changes.

Checklist

  • Self-review completed
  • Tests passing
  • Branch synced with base branch
  • Code follows project style guidelines
  • Performance implications considered
  • Security implications considered
  • No sensitive information included
  • Version bumped appropriately

Testing

Dependencies

Documentation

  • README updated if needed.
  • API documentation updated.
  • Comments added to complex code.
  • Change log updated.

Deployment Notes

Screenshots

divyesh87
divyesh87 reviewed Nov 26, 2024
View reviewed changes
src/config/chainConfig.ts Show resolved Hide resolved
src/lib/DeBridge/parser.ts Outdated
type: ACTION_ENUM.BRIDGE_OUT,
fromChain: transaction.chainId,
toChain: Number(parsedLog.args.chainIdTo),
fromToken: parsedLog.args.feeParams.isNativeToken ? ethers.ZeroAddress : transaction.to.toLowerCase(),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are you sure about this?
what if the its a token being bridged out but fees being paid in native token?
Please confirm this scenario!

also no need to lowercase token addresses. return them as it is
anywhere any address requires no need of any conversion, its being handled outside

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also in case its not native you are saving the fromToken as the "to" field of the transaction?
to will be the contract address

@divyesh87 divyesh87 closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divyesh87 divyesh87 divyesh87 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Debridge integration
2 participants
@takshakmudgal @divyesh87