Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowchart edges not found: Diagram db getEdges returining edges which aren't drawn on DOM #5516

Closed
ad1992 opened this issue May 13, 2024 · 1 comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@ad1992
Copy link
Contributor

ad1992 commented May 13, 2024

Description

Diagram db getEdges sometimes returns edges which aren't drawn or DOM for flowchart

Steps to reproduce

Let's consider the 👇🏻 mermaid code

flowchart TB   
    subgraph conference
        frontend
        backend
        security
    end
    frontend --> |Dive into frontend frameworks| conference
    backend --> |Learn all about backend| conference
    security --> |securing web apps| conference

For the above this 👇🏻 is the mermaid output

Screenshot 2024-05-13 at 12 49 47 PM

As its clear that none of the edges are drawn even though the diagram db getEdges returns 👇🏻

[
    {
        "start": "frontend",
        "end": "conference",
        "type": "arrow_point",
        "text": "Dive into frontend frameworks",
        "labelType": "text",
        "stroke": "normal",
        "length": 1
    },
    {
        "start": "backend",
        "end": "conference",
        "type": "arrow_point",
        "text": "Learn all about backend",
        "labelType": "text",
        "stroke": "normal",
        "length": 1
    },
    {
        "start": "security",
        "end": "conference",
        "type": "arrow_point",
        "text": "securing web apps",
        "labelType": "text",
        "stroke": "normal",
        "length": 1
    }
]

So this should be fixed in the code so that the getEdges returns correct set of edges

Screenshots

No response

Code Sample

No response

Setup

  • Mermaid version:
  • Browser and Version: [Chrome, Edge, Firefox]

Suggested Solutions

No response

Additional Context

No response

@ad1992 ad1992 added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels May 13, 2024
@nirname
Copy link
Contributor

nirname commented Jun 19, 2024

@ad1992 I am closing this issue because it seems that you had already fixed it, but merging PR did not closed the issue, because you had had to use magic comment like "resolves #issue_number"

@nirname nirname closed this as completed Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

2 participants