TypeError: Cannot read properties of undefined (reading 'shape') in nodes.ts

[guilhem]

Description

I encountered a TypeError: Cannot read properties of undefined (reading 'shape')

mermaid/packages/mermaid/src/rendering-util/rendering-elements/nodes.ts

Line 18 in ece3b25

if (node.shape === 'rect') {

Steps to reproduce

1. Use a node without a shape property.
2. Call the insertNode function.

Screenshots

Code Sample

No response

Setup

• Mermaid version: 11.4.0
• Browser and Version: Chrome

Suggested Solutions

import { isValidShape } from './shapes.js';
//...
export async function insertNode(elem: SVGGroup, node: Node, renderOptions: ShapeRenderOptions) {
  if (!isValidShape(node.shape)) {
    throw new Error(`Invalid shape: ${node.shape}. Please check your syntax.`);
  }
  const shapeHandler = shapes[node.shape];
  //...
}

Additional Context

No response

[husainsaifuddin]

Can this bug be assigned to me?

[sidharthv96]

Just to be clear, there's no need to wait for issues to be assigned before working on them. If you're interested in working on an issue, you can leave a comment so that others can see it. PRs are the way we usually link issues to contributors. So you can directly open a PR with the issue number in title/description, and GitHub will link those.

The reason why we don't assign issues is that it adds a lot of friction, waiting for someone to assign issues, work gets abandoned (life happens, and we're all doing it for free, so no issues with it), and others won't pick up the issue if it's already assigned. It's hard for maintainers to keep track of abandoned issues and unassign them, etc.

TLDR; There's no need to request issues to be assigned to you, just raise the PR directly!