Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowchart ugly self linking nodes #6049

Open
pinage404 opened this issue Nov 11, 2024 · 3 comments
Open

Flowchart ugly self linking nodes #6049

pinage404 opened this issue Nov 11, 2024 · 3 comments
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect

Comments

@pinage404
Copy link

Description

Until 11.0.2, self linking node was pretty
image

Broken in 11.1.0

Ugly since 11.1.1 #5828
image

Still ugly in the develop branch

Steps to reproduce

  1. create a flowchart
  2. add a self referencing node

Screenshots

No response

Code Sample

flowchart TB
    start([Start])
    ==> green([Change some code])
    ==> finish([Finish])

    green -.->|Incomplete ?| green

    classDef green_phase font-weight:bold,color:black,fill:#1cba1c;
    class green green_phase

Setup

  • Mermaid version: 11.1.1 and above
  • Browser and Version: Zen 1.0.1-a.18 (Firefox 132.0.1) (64 bits)

Suggested Solutions

No response

Additional Context

No response

@pinage404 pinage404 added Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect labels Nov 11, 2024
@waimea-cpy
Copy link

I think this is also covered in #5827

I just added a comment there to say exactly the same thing!

@floWetzels
Copy link

I experienced the same problem. Just dropping this here to raise attention. The issue is particularly annoying as it suddenly appeared in README.md files of GitHub projects that had flawless rendering earlier.

Is there a way to select a specific version in markdown-embedded mermaid graphs?

@0x822a5b87
Copy link

0x822a5b87 commented Dec 26, 2024

issue

I encounter the same issue and I believe it was due the render of mermaid, the defaultRenderer of mermaid is dagre, There is a workaround that can fix it by explicitly specifying the renderer of the flowchart as follows, the output of your code will be rendered with a elk:

---
config:
    flowchart:
        defaultRenderer: elk
---

Unfortunally, it seems like that github doesn't support elk yet, but it works in mermaid live and my local VSCode.

mermaid-elt-renderer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage Needs to be verified, categorized, etc Type: Bug / Error Something isn't working or is incorrect
Projects
None yet
Development

No branches or pull requests

4 participants