-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES 5.0 changes #594
Comments
@nubunto Thanks for looking into this!
|
@frankscholten no problem!
|
@nubunto Thank you very much for looking into this. We are very interested in having an ES 5.0 working cluster. Are you still working on this? Any progress? |
@albertostratio no problem! 😄 So, I got to a point where I can deploy ES 5.0 and it doesn't fail every second. We can reach it normally. The problem is:
I guess I should detach from this, since Java is not my main game. I'll publish a branch with those changes and hopefully you guys can take that forward. |
opened up PR #597 |
@nubunto I'm having some problems trying to build thermeon:es-5.0. Can you build it correctly? Apart from some trivial changes as changing new List to new ArrayList, I think we still need to pass the ES configuration that was built by esArguments and passed by args, someway with ES 5.x (elasticsearch.yml and/or jvm.options files). |
I started looking at this as we want a v5.2.0 cluster on DC/OS. I think that the command line arguments can still be passed to an official elasticsearch docker image, although the format is different; see option "D" in the reference docs. Broadly, cmdline opts are passed with |
@jcortejoso I'll give it a look and get back to you |
I took a fork of the repo and tried to build a local docker image using the gradle scripts ( |
Refer #551 |
This is just a summary of all the changes I needed to make in order to get a working ES 5.0 cluster working (ish) last week.
We can no longer pass arguments to ES 5.0 via command line, so all of this code breaks the executor. Not sure how to go by this, but apparently we need to have a default
elasticsearch.yml
passed to ES, instead of a bunch of command line arguments.The
vm.max_map_count
kernel config needs to be increased on the host, according to their docs. Although not directly related with this project, still worth mentioning in a troubleshooting area if the executor keeps getting killed all the time. They don't mention it on the docs, but this is a bootstrap error.There is no
easyway to get backwards compatibility regarding ES_HEAP_SIZE vs ES_JAVA_OPTS. We have to cut it out completely for ES > 5.0 and we need it for ES 2.x. Which means that, at configuration time, we need to know what is the version of elasticsearch we're going for, in order to use the correct environment variable.The text was updated successfully, but these errors were encountered: