Skip to content
This repository has been archived by the owner on Sep 23, 2022. It is now read-only.

Switch to non-jQuery version of Cropper #28

Open
GCheung55 opened this issue Jan 6, 2018 · 3 comments
Open

Switch to non-jQuery version of Cropper #28

GCheung55 opened this issue Jan 6, 2018 · 3 comments

Comments

@GCheung55
Copy link

Ember is moving away from jQuery. Consider switching to use non-jQuery version of Cropper;

@RobbieTheWagner
Copy link
Collaborator

Definitely a good idea 👍. Do you have any interest in submitting a PR for it?

@0000marcell
Copy link
Contributor

I was solving this issue, but got stuck...
i'm able to use cropperjs and everything works fine but when i call getCroppedCanvas() a second time nothing is returned
the relevant code:

getCroppedAvatar() {
      let cropper = this.get('cropper'),
          croppedImage = cropper.getCroppedCanvas();
      this.set('croppedAvatar', croppedImage);
    }

and the cropper declaration:

let image = document.querySelector(
      properties['cropperContainer']);
    this.set('cropper', new Cropper(image, properties));

the second time getCroppedAvatar() runs nothing is returned from getCroppedCanvas()
any help is appreciated, the entire code can be seen https://github.com/0000marcell/ember-cli-image-cropper

@RobbieTheWagner RobbieTheWagner self-assigned this Jan 25, 2018
@RobbieTheWagner
Copy link
Collaborator

@0000marcell would you mind going ahead and opening a PR, so we can see the diff? I can help try to debug from there.

@RobbieTheWagner RobbieTheWagner removed their assignment Dec 4, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants