Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Extend Namespaces to Providers #484

Open
Grant-Archibald-MS opened this issue Nov 23, 2024 · 0 comments
Open

[Feature]: Extend Namespaces to Providers #484

Grant-Archibald-MS opened this issue Nov 23, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@Grant-Archibald-MS
Copy link
Contributor

Grant-Archibald-MS commented Nov 23, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.

Namespaces only apply to function modules not providers. To implement the ring deployment model, the provider should expose a list of Namespaces.

Describe the solution you'd like

Proposed Solution

  • The provider should expose a list of Namespaces.
  • The namespaces should be checked against Test Settings to verify that the namespace is in the allow list.
  • If the namespace is not in the allow list, the provider should not be loaded.

Implementation

  • Update the provider to include a method that returns a list of Namespaces.
  • Check the returned namespaces against the Test Settings allow list.
  • Prevent loading of the provider if any namespace is not in the allow list.

Describe alternatives you've considered

No response

Additional context?

No response
@Grant-Archibald-MS Grant-Archibald-MS added the enhancement New feature or request label Nov 23, 2024
Grant-Archibald-MS added a commit that referenced this issue Nov 23, 2024
@Grant-Archibald-MS
Adding Namespace check for providers #484
8e37f34
@Grant-Archibald-MS Grant-Archibald-MS mentioned this issue Nov 23, 2024
Merged
8 tasks
snamilikonda added a commit that referenced this issue Dec 11, 2024
@Grant-Archibald-MS @snamilikonda
Namespace checks for IUserManager and ITestWebProvider (#486)
3c340b4 
* Adding Namespace check for providers #484

* Review edit

* Adding changes also for IUserModule in #485

* Review edits

* Review edits

* adding auth to validateprovider, removing duplicate proj in sln

* missing in merge

* comment null checks

---------

Co-authored-by: Sourabh Namilikonda <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Grant-Archibald-MS