Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Authentication of gemini pro models using service account file on google cloud #2508

Closed
ghost opened this issue Apr 25, 2024 · 13 comments · Fixed by #2805
Closed
Labels
models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.)

Comments

@ghost
Copy link

ghost commented Apr 25, 2024

Is your feature request related to a problem? Please describe.

All enterprise cloud projects use service account file keys to authenticate. Autogen llm configuration does not support the service account file keys at the moment, rather authenticates with api keys. Pleaase make this feature available.

Describe the solution you'd like

Autogen assistant and Userproxy agents to support LLM configurations using service account files.

Additional context

No response

@ghost ghost added the enhancement label Apr 25, 2024
@ekzhu ekzhu added the models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.) label Apr 25, 2024
@ekzhu
Copy link
Collaborator

ekzhu commented Apr 25, 2024

Thanks! If you know how to do this, could you submit a PR?

@ghost
Copy link
Author

ghost commented May 6, 2024

Hello team, is there any update on this feature?

@ekzhu
Copy link
Collaborator

ekzhu commented May 6, 2024

cc @BeibinLi

@BeibinLi
Copy link
Collaborator

BeibinLi commented May 6, 2024

@sadiqgpasha89 Thanks for this feature request. Since I don't have access to any enterprise account, do you have any pointers (links, documentations, etc.) on how to use the service account file keys from enterprise? Thanks ahead~

@ghost
Copy link
Author

ghost commented May 7, 2024 via email

@ekzhu
Copy link
Collaborator

ekzhu commented May 8, 2024

@sadiqgpasha89 this is a difficult one for us to do as we don't have access to the account. We are replying on the open-source community for this one.

@arjun-g
Copy link

arjun-g commented May 25, 2024

Gemini is available as part of 2 separate offerings of Google - Google AI and Vertex AI. Vertex AI is available for enterprise as part of the Google Cloud with some additional capabilities. (https://medium.com/@martareyessuarez25/what-are-vertex-ai-and-google-ai-studio-the-artificial-intelligence-development-tools-that-already-666bdfe85dbd#:~:text=Difference%20between%20Vertex%20AI%20and%20Google%20AI%20Studio)

The GeminiClient available in AutoGen can only support Google AI's Gemini as Vertex AI use different python library "vertexai". I have built a seperate VertexClient for my use. If I want to give PR should I build it as a seperate client or merge the functionalities with the existing GeminiClient ?

@sonichi
Copy link
Contributor

sonichi commented May 26, 2024

Gemini is available as part of 2 separate offerings of Google - Google AI and Vertex AI. Vertex AI is available for enterprise as part of the Google Cloud with some additional capabilities. (https://medium.com/@martareyessuarez25/what-are-vertex-ai-and-google-ai-studio-the-artificial-intelligence-development-tools-that-already-666bdfe85dbd#:~:text=Difference%20between%20Vertex%20AI%20and%20Google%20AI%20Studio)

The GeminiClient available in AutoGen can only support Google AI's Gemini as Vertex AI use different python library "vertexai". I have built a seperate VertexClient for my use. If I want to give PR should I build it as a seperate client or merge the functionalities with the existing GeminiClient ?

@BeibinLi @marklysze do you have a suggestion?

@marklysze
Copy link
Collaborator

Looking at the migration steps from Gemini AI to Vertex AI, they do seem to be fairly similar, main difference is authentication.

However, if @arjun-g has already built a library, it may be more straightforward to have two separate clients. For a developer to change their code base from GeminiClient to VertexClient it should be simple.

@arjun-g
Copy link

arjun-g commented May 27, 2024

I have a pending PR #2793. I will raise a PR for VertexClient once this is approved.

@luxzoli
Copy link
Contributor

luxzoli commented May 28, 2024

I have created a PR which solves this issue as well: 2805

@BeibinLi
Copy link
Collaborator

@luxzoli Thanks for your great PR! I will take a look at it.
@arjun-g Please also take a look at luxzoli's PR. For your function calling PR, can you add a few test cases, similar to luxzoli's?

@luxzoli
Copy link
Contributor

luxzoli commented May 29, 2024

@BeibinLi thanks a lot! Meanwhile I have added an additional configuration parameters for the compute regions in my PR 2805, when using Gemini via VertexAI and a service account key file (or simply google default auth even with personal Google Cloud account), which can also be an important enterprise requirements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
models Pertains to using alternate, non-GPT, models (e.g., local models, llama, etc.)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants