-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Add] Added function calling support to GeminiClient #2793
Conversation
I am learning python just for the past few days. Kindly give me feedback on what I can improve in this. |
Thanks for your great PR @arjun-g !! There are two tiny stuff missing: test cases and tutorial notebook. |
…el. Added test case for function_call.
@BeibinLi added a test case. Let me know if this is suffice |
@arjun-g - A notebook example of using this would be great to have. |
@BeibinLi added a notebook as well. |
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
11616921 | Triggered | Generic High Entropy Secret | 6563248 | notebook/agentchat_agentops.ipynb | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2793 +/- ##
==========================================
- Coverage 32.45% 25.59% -6.87%
==========================================
Files 93 99 +6
Lines 10109 10261 +152
Branches 2172 2358 +186
==========================================
- Hits 3281 2626 -655
- Misses 6544 7325 +781
- Partials 284 310 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Is there anything else you need here @arjun-g? This is an important component for the gemini client I'd love to make use of in a more official capacity. I'm happy to help wrap up. |
@robraux I am held up in a work. Will update the PR in couple of days, |
It would be really nice to have this feature 🙂 |
Looking forward to having this feature 🙂 |
@arjun-g I have prepared a pull request to your repo that would resolve the merge conflicts, synchronize updates from the upstream autogen repo, and also add support for tool config with function calling. Only changes to gemini.py , test_gemini.py , and openai_utils.py need to be reviewed, as the rest is changed due to synchronization with the official autogen repo except for agentchat_gemini.ipynb, where the difference is only automated formatting, which is not visible to the user anyway and thus irrelevant. I hope this would save you some effort in case you still do not have time to finish this PR 🙂 Link to the PR: arjun-g#1 |
@arjun-g please let us know this week. Thanks! |
Closing this as work continue in #3726 |
Why are these changes needed?
I have added function calling ability to GeminiClient so that we can use autogen tools with Gemini as well.
Related issue number
Completes "Function Calling" roadmap item in #2387
Checks