-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Function Calling Support for Gemini - Part 2 #3726
Conversation
…el. Added test case for function_call.
…en function response and user message
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
12853598 | Triggered | Generic High Entropy Secret | 64af078 | test/oai/test_utils.py | View secret |
10404693 | Triggered | Generic High Entropy Secret | 64af078 | test/oai/test_utils.py | View secret |
12853599 | Triggered | Generic High Entropy Secret | 64af078 | test/oai/test_utils.py | View secret |
10404694 | Triggered | Generic High Entropy Secret | 64af078 | test/oai/test_utils.py | View secret |
12853601 | Triggered | Generic High Entropy Secret | 64af078 | test/oai/test_utils.py | View secret |
10404696 | Triggered | Generic High Entropy Secret | 64af078 | test/oai/test_utils.py | View secret |
10422482 | Triggered | Generic High Entropy Secret | 64af078 | test/oai/test_utils.py | View secret |
12853602 | Triggered | Generic High Entropy Secret | 64af078 | test/oai/test_utils.py | View secret |
11616921 | Triggered | Generic High Entropy Secret | 6563248 | notebook/agentchat_agentops.ipynb | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine with me though we cannot test Gemini in our CI.
@luxzoli Thanks! A couple of tests are failing in CI. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 0.2 #3726 +/- ##
======================================
Coverage ? 29.15%
======================================
Files ? 115
Lines ? 12813
Branches ? 2431
======================================
Hits ? 3735
Misses ? 8733
Partials ? 345
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@ekzhu should I prepare a new PR with the updated costs? They are slightly different now for Gemini 1.5 Pro and Gemini 1.5 Flash |
Why are these changes needed?
Finalize the Gemini function calling PR #2793 from @arjun-g, plus include support for VertexAI tool config for function calling.
Related issue number
Relates to #2387
Checks