Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Function Calling Support for Gemini - Part 2 #3726

Merged
merged 73 commits into from
Oct 10, 2024

Conversation

luxzoli
Copy link
Contributor

@luxzoli luxzoli commented Oct 9, 2024

Why are these changes needed?

Finalize the Gemini function calling PR #2793 from @arjun-g, plus include support for VertexAI tool config for function calling.

Related issue number

Relates to #2387

Checks

arjun-g and others added 30 commits May 25, 2024 23:37
Copy link

gitguardian bot commented Oct 9, 2024

⚠️ GitGuardian has uncovered 9 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

Since your pull request originates from a forked repository, GitGuardian is not able to associate the secrets uncovered with secret incidents on your GitGuardian dashboard.
Skipping this check run and merging your pull request will create secret incidents on your GitGuardian dashboard.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
12853598 Triggered Generic High Entropy Secret 64af078 test/oai/test_utils.py View secret
10404693 Triggered Generic High Entropy Secret 64af078 test/oai/test_utils.py View secret
12853599 Triggered Generic High Entropy Secret 64af078 test/oai/test_utils.py View secret
10404694 Triggered Generic High Entropy Secret 64af078 test/oai/test_utils.py View secret
12853601 Triggered Generic High Entropy Secret 64af078 test/oai/test_utils.py View secret
10404696 Triggered Generic High Entropy Secret 64af078 test/oai/test_utils.py View secret
10422482 Triggered Generic High Entropy Secret 64af078 test/oai/test_utils.py View secret
12853602 Triggered Generic High Entropy Secret 64af078 test/oai/test_utils.py View secret
11616921 Triggered Generic High Entropy Secret 6563248 notebook/agentchat_agentops.ipynb View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Copy link
Collaborator

@ekzhu ekzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine with me though we cannot test Gemini in our CI.

@ekzhu
Copy link
Collaborator

ekzhu commented Oct 9, 2024

@luxzoli Thanks! A couple of tests are failing in CI.

@ekzhu ekzhu added the 0.2 Issues which are related to the pre 0.4 codebase label Oct 9, 2024
@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2024

Codecov Report

Attention: Patch coverage is 1.97368% with 149 lines in your changes missing coverage. Please review.

Please upload report for BASE (0.2@3ebd7ae). Learn more about missing BASE report.

Files with missing lines Patch % Lines
autogen/oai/gemini.py 1.97% 149 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##             0.2    #3726   +/-   ##
======================================
  Coverage       ?   29.15%           
======================================
  Files          ?      115           
  Lines          ?    12813           
  Branches       ?     2431           
======================================
  Hits           ?     3735           
  Misses         ?     8733           
  Partials       ?      345           
Flag Coverage Δ
unittests 29.15% <1.97%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@luxzoli
Copy link
Contributor Author

luxzoli commented Oct 10, 2024

@ekzhu should I prepare a new PR with the updated costs? They are slightly different now for Gemini 1.5 Pro and Gemini 1.5 Flash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.2 Issues which are related to the pre 0.4 codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants