Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package-level JS config files #1021

Open
ecraig12345 opened this issue Nov 25, 2024 · 0 comments
Open

Package-level JS config files #1021

ecraig12345 opened this issue Nov 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@ecraig12345
Copy link
Member

This is just a tracking issue, not necessarily something there's a plan to implement unless there's a compelling need.

Originally, beachball intended to allow JS config files per-package. This was broken in #405 which appears to be unintentional. (It also may not have been working quite as expected to begin with because the logic prior to that PR would have searched up and returned the repo config if there was no package config.) Even though removal of this feature was unintentional, it's been gone for a long time now (meaning nobody is relying on it), and restoring the behavior of searching for a bunch of config files when reading each package would slow down perf.

If we need package-level JS configs in the future, a better approach would be to support a package.json beachball property which is a string pointing to the config file: e.g. "beachball": "beachball.config.js". Then use cosmiconfig 's load(packageJson.beachball) to load the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant