Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FAILED tests/test_sklearn_bagging.py::TestSklearnBagging::test_bagging_logistic_regression - AssertionError #773

Open
mshr-h opened this issue May 28, 2024 · 2 comments · May be fixed by #774
Labels
bug Something isn't working

Comments

@mshr-h
Copy link
Collaborator

mshr-h commented May 28, 2024

log: Build · microsoft/hummingbird@ae958a2

=========================== short test summary info ============================
FAILED tests/test_sklearn_bagging.py::TestSklearnBagging::test_bagging_logistic_regression - AssertionError: 
Not equal to tolerance rtol=1e-06, atol=1e-06

Mismatched elements: 200 / 200 (100%)
Max absolute difference: 0.99875297
Max relative difference: 0.99875297
 x: array([[9.809476e-01, 1.905245e-02],
       [9.987530e-01, 1.247026e-03],
       [8.200397e-01, 1.799603e-01],...
 y: array([[0., 1.],
       [0., 1.],
       [0., 1.],...
FAILED tests/test_sklearn_decomposition.py::TestSklearnCrossDecomposition::test_pca_converter_two - AssertionError: 
Not equal to tolerance rtol=1e-06, atol=2e-05

Mismatched elements: 8 / 8 (100%)
Max absolute difference: 3.00190626
Max relative difference: 0.89631042
 x: array([[ 0.260879,  0.153022],
       [ 0.606673,  0.456342],
       [ 6.468562,  6.489316],
       [11.763886, 12.001321]])
 y: array([[1.52568 , 1.475772],
       [2.433673, 2.35843 ],
       [6.256389, 6.266384],
       [8.884257, 8.999414]])
====== 2 failed, 387 passed, 275 skipped, 58 warnings in 82.84s (0:01:22) ======

cc: @ksaur @interesaaat

@mshr-h
Copy link
Collaborator Author

mshr-h commented May 28, 2024

This is the latest ok log. Build · microsoft/hummingbird@d2aa5dc
Seems like scikit-learn-1.5.0 is the problem.

@mshr-h
Copy link
Collaborator Author

mshr-h commented May 28, 2024

According to the Version 1.5—scikit-learn 1.5.0 documentation, ensemble.BaggingClassifier and cross_decomposition.PLSRegression have changed something. Have those changes caused the errors?

Feature ensemble.BaggingClassifier and ensemble.BaggingRegressor now support metadata routing. The fit methods now accept **fit_params which are passed to the underlying estimators via their fit methods. #28432 by Adam Li and Benjamin Bossan.

Fix The coef_ fitted attribute of cross_decomposition.PLSRegression now takes into account both the scale of X and Y when scale=True. Note that the previous predicted values were not affected by this bug. #28612 by Guillaume Lemaitre.

@mshr-h mshr-h added the bug Something isn't working label May 28, 2024
@ksaur ksaur linked a pull request May 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant