-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] v0.51.0 breaks for browser based imports #4654
Comments
This is because the blob context cannot load relative urls. |
Potential fix: microsoft/vscode@634933e |
I just tried it out in my use-case with v0.52.0. Not sure if the hotfix-candidate was already in there. As mentioned inside my last comment: I really think the main issue is that You are welcome to ping me, in case you need help. We could do a quick screen-sharing session to enable you to run my use-case locally. |
Same error using |
Same Issue here. I'm blocked from use the latest versions due to this. |
We in the Effect-TS org have also started experimenting with re-writing our playground (which leverages Monaco) to be bundled with Vite instead of dynamically loaded from a CDN. While we are able to successfully run our playground, the issue that @tobiu described in great detail with |
@aiday-mar I notice this issue did move to the backlog, we had to downgrade to Monaco v0.50 to prevent this error in the meantime. Is there any way to prevent this error or suggested work around to allow for an upgrade? |
I feel this issue is also related to the issue I am facing when trying to upgrade from 0.43.0 to 0.52.0 in my browser extension.
And
|
Hello, |
Same problem with 0.52.0 |
I would add that your Monaco Editor playground is also affected by this bug ... |
Reproducible in vscode.dev or in VS Code Desktop?
Reproducible in the monaco editor playground?
Monaco Editor Playground Link
No response
Monaco Editor Playground Code
No response
Reproduction Steps
upgrade from v0.50.0 to v0.51.0
Actual (Problematic) Behavior
v0.50.0 was including the script:
editor/editor.main.nls.js
.this silently got removed in v0.51.0 without getting mentioned inside the release log:
e52ff42
after removing the script as well inside the Neo.mjs env, i encountered several errors and warnings:
Expected Behavior
there should be no undocumented breaking changes in minor versions.
Additional Context
cross-reference ticket:
neomjs/neo#5822
The text was updated successfully, but these errors were encountered: