Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build spits out seemingly harmless warning #138361

Closed
joaomoreno opened this issue Dec 2, 2021 · 3 comments
Closed

Build spits out seemingly harmless warning #138361

joaomoreno opened this issue Dec 2, 2021 · 3 comments
Assignees
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Milestone

Comments

@joaomoreno joaomoreno added the engineering VS Code - Build / issue tracking / etc. label Dec 2, 2021
@lramos15
Copy link
Member

lramos15 commented Dec 3, 2021

I wouldn't say it's a harmless warning. jschardet doesn't provide a main or browser entrypoint in their package.json which means we have no idea where to load it from. I assume there's a dist/*.min.js file but don't actually check just because I knew there was one for jschardet. This is extremely flaky in that if we add additional packages in the future without the same file structure they won't load if they don't provide an entrypoint. The real fix is this PR being merged aadsm/jschardet#73

@joaomoreno
Copy link
Member Author

joaomoreno commented Dec 3, 2021

Then maybe let's log it for any package other than the ones we hardcode assumptions to: for now that's jschardet only.

@lramos15 lramos15 added this to the November 2021 milestone Dec 3, 2021
@lramos15
Copy link
Member

lramos15 commented Dec 3, 2021

I've suppressed the jschardet warning. Ideally when that PR is added we can warn or even error out on all non entrypoint packages because it is really something to be careful of since the loader has no way of knowing.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
engineering VS Code - Build / issue tracking / etc. insiders-released Patch has been released in VS Code Insiders
Projects
None yet
Development

No branches or pull requests

3 participants
@joaomoreno @lramos15 and others