-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First usage feedback: multiple non-silent fails, one crash, and two types of repeats #1009
Comments
Edit: I'm hijacking this initial response to put the list of related features so it's easier to see progress. I'll continue to make edits in this top response as we continue discussing topics on this thread. In general, we have been looking to close these "large collection of issues" Issues, but as this one was early and so helpful, I'm going to keep it open and honor the original intent.
@Master-Guy this is awesome feedback! Thank you for taking the time to be so thorough here. There are several different things you are reporting. I think we have Issues for many of them. Be sure to add your 👍 to those issues to help us prioritize. There may be a couple of new asks. I don't think anyone has created a new feature to request the ability to specify either a preference or a requirement for a setting in Edit: It's this one: The "list" command/feature is used to do most of the heavy lifting to match manifests in the source to Apps in Add / Remove Programs. In some cases, an adjustment to a manifest will address failure to update. In other cases, we have features to add additional keys to the manifest to help with better matching. The "main" actionable item we can look at in the client in this issue is "kill a running download when pressing CTRL+C." |
Thank you! I'm really looking forward to using this on an enterprise level, but it requires some finetuning :) |
We've made improvements for [Ctrl]+[C] in several areas. Can you confirm if the "kill a running download when pressing CTRL+C" is resolved? I believe we've isolated most of the other issues you've reported. The work is ongoing and primarily tracked with #1243. |
@denelon thank you for getting back to me. Since I've re-installed my Windows, a lot of the checks are uncheckable for me now. Ryzen fails due to failed version comparison: Discord fails due to it still running:
Unity is still being installed as a separate version when doing |
We've been busy making tons of improvements and we're close to getting Windows Package Manager 1.3 flighted for "Windows Insider Release Preview". That's the last step before GA. Are there any problems you're having that haven't been reported yet? I think we're close to being able to close this issue 😊 |
No, this is a bug (or a pair of them depending on how one perceives things). I'm able to reproduce both errors. You are correct, the intent of "winget upgrade --all --accept-package-agreements" would be to upgrade all packages and accept their agreements to avoid an interactive prompt per agreement. I know we've been doing some refactoring for arguments that "don't make sense" or conflict with each other. I'm guessing we haven't seen this particular report due to the fact that none of the packages in the "winget" source have "Agreements" today, and the "msstore" source isn't providing version numbers in the upgrade flow for us to detect when upgrades are available (yet). |
That's a lovely collection of packages :) |
I had a quick chat with engineering. We're going to confirm the behavior of having both "--all" and "--accept-package-agreements" for upgrade (in an open PR). The "--log" argument is where the "installer" places it's logs (if supported). It likely the file would get overwritten by each subsequent installer. In a world where parallel install is supported (MSIX only) it gets even messier. We're going to need to think about trying to place "all" installer logs from commands that operate on sets of packages into one location. |
We've been making lots of progress on WinGet. We announced WinGet configuration and Dev Home at Microsoft Build this year. I just finished "hijacking" my initial reply to keep track of the related issues at the top of this Issue. @Trenly has been helping as a community moderator over at winget-pkgs and we recently got an update for the fabric bot used here to help put labels on issues and build rules so the moderators can help with triage. He suggested an update here this morning since he's been plowing through the open issues. Another set of notable improvements to help with troubleshooting have also been added. You can now specify verbose logging in your settings, and you can use "--open-logs" or the shorter "--logs" to launch the file explorer with the log directory after the command completes. If you don't want to default to verbose logs in settings, you can use "--verbose-logs" as an argument. The Visual Studio and .NET teams have automated publishing for their packages in the WinGet community repository, and lots of other bugs have been discovered (some of them have even been squashed). I'd love to get an update on your end to see how we've made progress (or not). |
I forgot to mention the PowerShell module which might also be more to your liking rather than trying to fight the CLI output. Issues related to the PowerShell cmdlets are labeled with "PowerShell". |
Hi @denelon, thank you for your reply and keeping up with this.
Going through the help message ( Combining all the wanted items, I reached the following command: Having the Also for the screenshot above: Even though Winget tells me that there are 33 upgrades available, it only wants to process 24? This is very confusing for me as an end-user, since I don't have any information on why this is. Information on the applications updating: The full logs for this set of update installations can be found here: After the full set, I ran Still in the list, even though it just updated according to the information I was shown:
Trying to install the Concluding this, all the feedback for this round:
|
Interesting. I see it in the screenshot you shared as
I completely agree. I believe this issue is being experienced by many users, and is tracked in
This is a great point, and I think @denelon noticed this a while ago in
This is great information. Some of them can be explained as known issues. For example - the Desktop Runtimes are installed side by side and are also heavily impacted by issues related to the Area-Matching Label. Others like OBS are actually an issue with the installer, as the publisher doesn't update the version reported in the registry.
This is another interesting point and I'm glad you brought it up. This definitely isn’t a good behavior, and it seems it is also caused by discord's auto update not updating the version in the registry. I'll take a look and see if the Discord manifest is set to require explicit upgrade to help prevent this issue.
This is an interesting artifact of how the upgrade flow is implemented and has resulted in other errors too like count of packages with unknown version being incorrect. The way the upgrade check works is by seeing if there is any manifest for the package with a version that is higher than what is currently installed, no filters are applied for OS Verison, OS Architecture, or previous installer types. When the upgrade is executed though, it does go through those filters which results in that very frustrating message. @denelon - Perhaps a separate issue should be created to filter out inapplicable updates in all areas of the upgrade flow?
I know @denelon has been working with the team to make improvements by trying to reason about how the Thank you for all the great feedback! I know its frustrating when things don’t work quite as they are supposed to or in the way you would expect. |
I've read, checked, and double-checked the help page.. Can't understand how I've missed that one.. Sorry ^^
Don't worry, I know this is WIP and things cannot improve without feedback. Seeing the community working on this makes it worth posting the feedback in the first place. Even now WinGET already helps me so much! |
We released WinGet 1.7 with a few improvements. We're also working on the PowerShell module. We had a hiccup with the UI.Xaml 2.8 dependency, but that seems to have been largely resolved (not completely though). I'm digging deep in the old bugs to review and see if any of them can be resolved. It's tedious work, but it's worth doing to try and keep the backlog clean. 😊 |
Hi @denelon |
^ Accidentally hit the wrong button |
We're going to have at least one more update to the WinGet 1.8 release candidate. We're making the new side-by-side behavior stable, and we're addressing an issue with downloading packages, dependencies, and licenses for the Microsoft Store UWP packages. I'd love to get an update after 1.8 is released. |
I'll wait with the updates for now then. Once 1.8 is released I'll do a full update. |
@Master-Guy we've released WinGet 1.9. We've also got the ability to have some parent child relationships with Issues here at GitHub. Now that an AI is also providing suggestions on issues, it might be good to close this one and work from a clean state. What do you think? |
Sounds good, I'll go ahead with updating the apps and opening a new issue. |
#5056 has been created |
Brief description of your issue
Sorry if this shouldn't be reported this way, but I'm not yet up-to-speed on the Microsoft ways-of-work on Github.
After installing winget-cli this morning, and running
winget upgrade --all
, I got the following feedback:Steps to reproduce
Have an old 32-bit version of Teamviewer installed on your 64 machine, together with any old version of the other apps listed below under Actual behaviour.
Then run
winget upgrade --all
as administrator in a Windows Terminal session running Powershell as default.Expected behavior
Winget to update these packages, and kill a running download when pressing CTRL+C.
Actual behavior
While downloading the Unity update of 2GB, I pressed CTRL+C because I needed my bandwidth for a Teams meeting, but it seems the download kept running even though I got my Powershell prompt back.
Multiple packages (also a number of packages not listed here) have visible installers. It wouldn't be too much of an issue if these would be running in the background, but they are being pushed as top window, and get the focus of Windows, which makes it possible to accidentally cancel an installation, otherwise interrupt an installation, or close an error message.
Mozilla Firefox, VLC media player, Zoom and Adobe Acrobat Reader DC aren't automatically updating at all with
winget upgrade --all
and returnNo applicable update found.
when trying to upgrade them one-by-one.Environment
Logs:
DiagOutputDir.zip
The text was updated successfully, but these errors were encountered: