-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive update throws Duplicate installer entry found #463
Comments
This bit is fine and expected. If you view the existing manifest on winget-pkgs or run This is related to: If you want to submit a PR for CPUID.CPU-Z, I would recommend running it through YamlCreate.ps1 for now. You could take the manifest generated from winget-create, modify the architectures in a text editor, and then use |
Thanks for the answer @mdanish-kh ! I also tried wingetcreate in non-interactive mode: But that gave me:
So I guess updating this specific package is just not possible using wingetcreate at the moment? You are welcome to close this issue if it essentially is a duplicate of #405. |
Unfortunately yes |
Brief description of your issue
First I want to say that I'm very new to this whole Github and winget thingy and just created my first pull requests today using wingetcreate. And I still don't fully understand everything. So please bear with me.
I picked CPU-Z as a first try as I noticed it having newer versions online. Maybe I picked a bad example.
When I
wingetcreate update CPUID.CPU-Z --version 2.08 -i
it will ask me 12 times for installers even though there exist only two installers - en and cn and both work for both x86 and x64 architectures.The 2.07 YAML lists the architectures separately (same download URL) and also lists 5 different locales for the cn installer.
Running through it and trying to update it gives me
Manifest validation succeeded: False Manifest Error: Duplicate installer entry found.
which makes sense to me.
So are the current yaml files just overly complicated or is it an issue of wingetcreate?
Steps to reproduce
In Terminal run:
wingetcreate update CPUID.CPU-Z --version '2.08' -i
and run through the interactive process providing the same URL for both architectures and use the en link for en-US and the cn link for all the **-cn languages.
https://download.cpuid.com/cpu-z/cpu-z_2.08-en.exe
https://download.cpuid.com/cpu-z/cpu-z_2.08-cn.exe
Expected behavior
As I only provide links as they are already present in the present yaml just with a newer version I would expect the manifest file to be successfully created, validated and uploaded.
Actual behavior
Manifest is saved locally though no pull request is created and an error is thrown instead:
Manifest validation succeeded: False Manifest Error: Duplicate installer entry found.
Environment
The text was updated successfully, but these errors were encountered: