Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update manifest: Nushell.Nushell version 0.100.0 #200911

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update manifest: Nushell.Nushell version 0.100.0 #200911

wants to merge 1 commit into from
+0 −1

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Dec 21, 2024 •
edited by microsoft-github-policy-service bot
Loading

What's changed

  • Remove Scope definition in top-level properties.
  • Duplicate installer entrance in Installers properties.
  • Explicitly add Scope definition for each entrance.

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.9 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 21, 2024
Trenly
Trenly suggested changes Dec 22, 2024
View reviewed changes
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wix installer and as such does not support user scope - it will always write the ARP entries to machine scope

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 22, 2024
Dragon1573
Dragon1573 commented Dec 23, 2024
View reviewed changes
Copy link
Contributor Author

@Dragon1573 Dragon1573 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

User scope should be removed from the manifest.

manifests/n/Nushell/Nushell/0.100.0/Nushell.Nushell.installer.yaml Outdated Show resolved Hide resolved
manifests/n/Nushell/Nushell/0.100.0/Nushell.Nushell.installer.yaml Outdated Show resolved Hide resolved
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Dec 23, 2024
auto-merge was automatically disabled December 23, 2024 03:40

Head branch was pushed to by a user without write access

@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed Changes-Requested Changes Requested labels Dec 23, 2024
Trenly
Trenly suggested changes Dec 23, 2024
View reviewed changes
Copy link
Contributor

@Trenly Trenly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And now the PR won’t fix the bug that it's linked to! Moving the scope to each individual installer will have no effect; The cleanest solution here is to make the scope undefined by removing it from the manifest entirely

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label Dec 23, 2024
@Dragon1573
Update manifest: Nushell.Nushell version 0.100.0
2f9777c 
- Remove `Scope` from top-level properties.

Signed-off-by: Dragon1573 <[email protected]>
@wingetbot
Copy link
Collaborator

/AzurePipelines run

@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Author-Feedback This needs a response from the author. label Dec 23, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Changes-Requested Changes Requested label Dec 23, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Dec 23, 2024
@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Dragon1573,

The check-in policies require a moderator to approve PRs from the community.

Our moderators are community volunteers, please be patient and allow them sufficient time to review your submission.

Template: msftbot/requiresApproval/moderator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trenly Trenly Trenly requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Issue]: Nushell.Nushell Installation doesn't respect the selected scope
4 participants
@Dragon1573 @wingetbot @Trenly @stephengillie