Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A possible error in chapter-11.ipynb/SharedAdam and SharedRMSprop #24

Open
MarginalCentrality opened this issue Apr 6, 2022 · 0 comments

Comments

@MarginalCentrality
Copy link

Maybe we need to change
"self.state[p]['steps'] = self.state[p]['shared_step'].item()" to
"self.state[p]['step'] = self.state[p]['shared_step'].item()", in both the step functions of SharedAdam and SharedRMSprop under chapter-11.ipynb. Becasue in the step function of Adam, "state[step]" is used rather than "state[steps]".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant