Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for allow_update_branch #155

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: add support for allow_update_branch #155

wants to merge 3 commits into from

Conversation

tobiasehlert
Copy link

  • add support for setting allow_update_branch with default being false

fix #132
rel #148 (similar except that it's not updating provider versions)

@tobiasehlert tobiasehlert requested review from mariux and a team as code owners April 28, 2023 11:14
@tobiasehlert tobiasehlert mentioned this pull request Apr 28, 2023
Open
shinenelson
shinenelson suggested changes May 2, 2023
View reviewed changes
Copy link

@shinenelson shinenelson left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As much as I want this change to be merged in without a breaking change, this change would also require a breaking change since the minimum required provider version would have to be bumped to >= 5.7.0.

The current provider version constraint for this module is >= 4.20, < 6.0.

terraform-github-repository/versions.tf

Line 12 in ee6001a

version = ">= 4.20, < 6.0"

allow_update_branch was added in provider version v5.7.0.

So the minimum required version for this module should be bumped to at least >= 5.7.0. Otherwise, users who has a lower provider version ( < 5.7.0 ) and use a pessimistic operator constraint for the module would have their code breaking.
This probably might be the reason why this change was also merged into #148

@tobiasehlert
Copy link
Author

As much as I want this change to be merged in without a breaking change, this change would also require a breaking change since the minimum required provider version would have to be bumped to >= 5.7.0.

The current provider version constraint for this module is >= 4.20, < 6.0.

terraform-github-repository/versions.tf

Line 12 in ee6001a

version = ">= 4.20, < 6.0"

allow_update_branch was added in provider version v5.7.0.
So the minimum required version for this module should be bumped to at least >= 5.7.0. Otherwise, users who has a lower provider version ( < 5.7.0 ) and use a pessimistic operator constraint for the module would have their code breaking. This probably might be the reason why this change was also merged into #148

added require of version to be ">= 5.8, < 6.0".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinenelson shinenelson shinenelson requested changes

@mariux mariux Awaiting requested review from mariux mariux is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Always suggest updating pull request branches
2 participants
@tobiasehlert @shinenelson