You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently, errors derived from thiserror (especially in the wallet) use Amount when errors occur. The problem with that is that the errors appear very unreadable for users, something in the form:
We can use DecimalAmount instead, but the issue there is that it doesn't implement Eq or PartialEq because equality can be achieved even if the contents inside are not the same, where different amounts with different amounts of decimals can be equal.
We either fix this, or we create yet another type for amount errors that assumes equality is only for all equal.
The text was updated successfully, but these errors were encountered:
TheQuantumPhysicist
added
UI
User-interface related issues (whether GUI, CLI or otherwise)
wallet
Everything related to the node wallets (whether GUI or CLI)
labels
Jan 18, 2024
Currently, errors derived from
thiserror
(especially in the wallet) useAmount
when errors occur. The problem with that is that the errors appear very unreadable for users, something in the form:We can use
DecimalAmount
instead, but the issue there is that it doesn't implementEq
orPartialEq
because equality can be achieved even if the contents inside are not the same, where different amounts with different amounts of decimals can be equal.We either fix this, or we create yet another type for amount errors that assumes equality is only for all equal.
The text was updated successfully, but these errors were encountered: