Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for removeListener or removeAllListener? #89

Closed
yushosei opened this issue Nov 19, 2024 · 5 comments · Fixed by #94 or #98
Closed

Support for removeListener or removeAllListener? #89

yushosei opened this issue Nov 19, 2024 · 5 comments · Fixed by #94 or #98

Comments

@yushosei
Copy link

yushosei commented Nov 19, 2024

Hi!
In my case
AddListner may have duplicate calls.
Do you have any plans to officially support the removeListener function for this?

I would like to handle it in the same way as

// Register the listener when the composable enters the composition
// and unregister it when it leaves
DisposableEffect(Unit) {
NotifierManager.addListener(notifierListener)
onDispose {
}
}

@not2exe
Copy link

not2exe commented Nov 24, 2024

We are also waiting for this method

@mirzemehdi
Copy link
Owner

@yushosei @not2exe okay will add setListener so you can set one listener, and when not needed you can set it as setListener(null). Would that work?

@yushosei
Copy link
Author

@mirzemehdi
the solution will work for me, thank you!

@mirzemehdi
Copy link
Owner

@yushosei @not2exe

just wanted to let you know that now in 1.4.0 version you can use
setListener(listener: Listener?) method to set one listener or set it as a null which will be like removeListener

@mirzemehdi mirzemehdi linked a pull request Dec 11, 2024 that will close this issue
@Tommyten
Copy link

@mirzemehdi Is there any reason for not providing a removeListener() functionality?
I can think of multiple use cases where removing a single Listener from the list of Notification Listeners would be pretty great to have, rather than removing all Listeners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants