Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disallow unauthenticated requests for privileged endpoints #10

Closed
HalosGhost opened this issue Sep 3, 2024 · 3 comments
Closed

Disallow unauthenticated requests for privileged endpoints #10

HalosGhost opened this issue Sep 3, 2024 · 3 comments

Comments

@HalosGhost
Copy link
Contributor

HalosGhost commented Sep 3, 2024

The mintTx endpoint is incredibly privileged operation. Right now, there's no restriction on interacting with that interface. This is unacceptable for a production-grade deployment.

Given the intended use-case this repository is exploring (unprivileged, non-custodied wallet providers), such an interface likely shouldn't/wouldn't actually exist in a productionized fork/recreation of this project. However, some variant of endpoint authentication would not go amiss, to make sure no one gets the wrong idea.

Originally posted by @anders94 in #6 (comment)

@HalosGhost
Copy link
Contributor Author

Note: this also requires some level of authentication to be present in the running equivalent of opencbdc-tx because authentication of privileged operations should be strict and verified (at least) at the boundaries of the security perimeter (which this repository sits outside).

cf. mit-dci/opencbdc-tx#98

@anders94
Copy link
Collaborator

anders94 commented Sep 3, 2024

This might be duplicated in #7 and #8

@HalosGhost
Copy link
Contributor Author

closing as a duplicate of already-open issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants