Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check print assumptions in CI #70

Open
upamanyus opened this issue Jun 21, 2024 · 1 comment
Open

Check print assumptions in CI #70

upamanyus opened this issue Jun 21, 2024 · 1 comment

Comments

@upamanyus
Copy link
Collaborator

Currently, make ci does not build the various print_assumptions.v files and check them. It would be nicer if it were easy to build them and validate that the axioms are unchanged.

As a concrete problem, I introduced admitted specs for waitgroup while changing the naming convention for sync, and nothing failed in CI due to those admits.

@tchajed
Copy link
Member

tchajed commented Jun 26, 2024

In general we don't have printing tests but we should copy that infrastructure from stdpp/Iris and then use it in a few places, including for print_assumptions.v. It would also be good to track regressions in printing GooseLang expressions, and other notations that are important for readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants