Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is it intentional that the default number format formatCode is "GENERAL" instead of "General" #351

Open
flummer opened this issue Oct 5, 2023 · 1 comment

Comments

@flummer
Copy link

flummer commented Oct 5, 2023

When I open a file created with XLSXWriter in Numbers on macOS, I get a warning on the header fields that states:

The data format couldn't be imported
Original format: GENERAL

I don't get this error in Excel on Windows or Libre Office on macOS

When I change it to "General" (5 places in xlsxwriter.class.php including one in a comment) the files open without warnings in all the above tested applications.

From ECMA 376 it seems to me that the formatCode should be "General", but maybe I'm missing something.

Should I make a PR to change this?

@maksimovic
Copy link

@flummer I've ported your changes to https://github.com/maksimovic/PHP_XLSXWriter/releases/tag/1.0.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants