Splink comparison viewer barplot and waterfall chart don't agree on match probability #2529
Open
2 tasks done
Labels
bug
Something isn't working
What happens?
Hello!
Splink comparison viewer barplot and waterfall chart don't seem to agree on the match probability. However, they agree on the match weight, which doesn't seem normal. The problem appears in the tutorial here:
https://moj-analytical-services.github.io/splink/demos/tutorials/06_Visualising_predictions.html
If you zoom to have all the bars with at least 10 records, then click on the bar with gamma_concat: 4, 4, 0, 0, -1, you can see that the estimated match probability is 82.8%, while the match weight is -1.17. If you then look at the waterfall chart, you can see that the estimated match probability is 0.308 (but with the same match weight of -1.17).
I have the same issue when running the comparison viewer with my own model and dataset.
Edit: it looks like the waterfall chart is right and that the barplot is wrong. In the screenshot I provided (this is a screenshot from the Splink tutorial: https://moj-analytical-services.github.io/splink/demos/tutorials/06_Visualising_predictions.html), the match weight is -1.17, which mean the associated match probability is (2^-1.17) / (1 + 2^-1.17) = 0.308
Thanks!
To Reproduce
OS:
Windows 11
Splink version:
4.0.5
Have you tried this on the latest
master
branch?Have you tried the steps to reproduce? Do they include all relevant data and configuration? Does the issue you report still appear there?
The text was updated successfully, but these errors were encountered: