Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make passing config file optional by adding a set of default configs #36

Open
abhineet97 opened this issue Aug 27, 2020 · 9 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@abhineet97
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Users have to pass a JSON formatted configuration file to start Taswira. This i

Describe the solution you'd like
I believe that we can make this configuration file optional by hard-coding a set of configs for all the common ecosystem indicators. We can build on the example config file that is available in the README:

[
  {
    "database_indicator": "NPP",
    "file_pattern": "NPP*.tiff",
    "graph_units": "Ktc",
    "palette": "Greens"
  },
  {
    "database_indicator": "NBP",
    "file_pattern": "NBP*.tiff",
    "palette": "Greens"
  },
  {
    "database_indicator": "NEP",
    "file_pattern": "NEP*.tiff",
    "palette": "Reds"
  },
  {
    "title": "AG Biomass",
    "database_indicator": "Aboveground Biomass",
    "file_pattern": "AG_Biomass_C_*.tiff",
    "palette": "YlGnBu",
    "graph_units": "Mtc"
  }
]
@abhineet97 abhineet97 added the enhancement New feature or request label Aug 27, 2020
@gmajan
Copy link
Member

gmajan commented Oct 8, 2020

@abhineet97 @Mohitkumar6122 would like to work on the visualisation tool. Would this be the best issue to start with? Can you pls assist to get this process going? thx.
Mohit can you share your email so I can add you to Slack? thx

@Mohitkumar6122
Copy link

@abhineet97 @Mohitkumar6122 would like to work on the visualisation tool. Would this be the best issue to start with? Can you pls assist to get this process going? thx.
Mohit can you share your email so I can add you to Slack? thx

my mail id : [email protected]
btw thanks for the opportunity.

@abhineet97
Copy link
Collaborator Author

Sure @gmajan, I'll try to help how ever I can.

Hi, @Mohitkumar6122

I would suggest you to go through the docs and setup your development environment. We can then discuss this issue.

Please feel free to open a new issue if you encounter any trouble while setting up.

Welcome to moja global!

@Mohitkumar6122
Copy link

Sure @gmajan, I'll try to help how ever I can.

Hi, @Mohitkumar6122

I would suggest you to go through the docs and setup your development environment. We can then discuss this issue.

Please feel free to open a new issue if you encounter any trouble while setting up.

Welcome to moja global!

i completed setup and installation but i am getting problem in usage , how to use it , could you explain me a little about it @abhineet97

@abhineet97
Copy link
Collaborator Author

abhineet97 commented Oct 13, 2020

@Mohitkumar6122, there's some sample data here. Please download it and also create a indicators.json file based on the example given above.

After that, try running by passing these files:

$ taswira indicators.json sample_data/sample_1/output_files/spatial sample_data/sample_1/output_files/compiled_gcbm_output.db

You're browser should automatically open up with Taswira's interface.

@Mohitkumar6122
Copy link

@Mohitkumar6122, there's some sample data here. Please download it and also create a indicators.json file based on the example given above.

After that, try running by passing these files:

$ taswira indicators.json sample_data/sample_1/output_files/spatial sample_data/sample_1/output_files/compiled_gcbm_output.db

You're browser should automatically open up with Taswira's interface.

Should i keep these files and json file in same directory as visulaization tool or somewhere else ?

@abhineet97
Copy link
Collaborator Author

abhineet97 commented Oct 17, 2020

@Mohitkumar6122, it doesn't matter where you keep them. You just need to pass their path as command-line parameters. Try providing absolute paths like /home/neet/files/ or C:\Users\Neet\Desktop.

Let me know if you encounter any problem but please create a new issue as this issue is going off-topic. In that issue please also include the operating system that you're using.

@Mohitkumar6122
Copy link

Mohitkumar6122 commented Oct 22, 2020

@Mohitkumar6122, it doesn't matter where you keep them. You just need to pass their path as command-line parameters. Try providing absolute paths like /home/neet/files/ or C:\Users\Neet\Desktop.

Let me know if you encounter any problem but please create a new issue as this issue is going off-topic. In that issue please also include the operating system that you're using.

Thanks now it is working fine .. !
Could you describe this issue to me .?

@abhineet97
Copy link
Collaborator Author

abhineet97 commented Nov 1, 2020

Yes, @Mohitkumar6122.

As described in the original description, I'm thinking about hard coding a set of default config values. I'm talking about the values that are read from the file passed in the config parameter of the CLI --- where you might've passed indicators.json while trying out the program.

Users would still be able to pass custom configs if they dislike the defaults. The main benefit would be that they wont have to worry about passing anything. This I believe, will make Taswira more user-friendly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants