Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

redundancy?? #342

Open
pnrobinson opened this issue Nov 9, 2024 · 1 comment
Open

redundancy?? #342

pnrobinson opened this issue Nov 9, 2024 · 1 comment
Labels
question Further information is requested
Milestone
Nice to have

Comments

@pnrobinson
Copy link
Member

We seem to have too highly similar predicates

from gpsea.analysis.predicate.genotype import diagnosis_predicate
from gpsea.analysis.predicate.phenotype import DiseasePresencePredicate

Do we really need both? I think the top predicate would be the one to keep. If the second predicate does something the first cannot, we should at least rename it.
@pnrobinson pnrobinson added the question Further information is requested label Nov 9, 2024
@ielis
Copy link
Member

ielis commented Nov 11, 2024

One uses diagnosis to assign individual into a genotype group and the other into a phenotype group. So, we need to see if this is useful.

@ielis ielis added this to the Nice to have milestone Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
question Further information is requested
Projects
None yet
Milestone
Nice to have
Development

No branches or pull requests
2 participants
@pnrobinson @ielis