Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture feedback about proposed table with "all associations together" #849

Closed
Tracked by #737
monicacecilia opened this issue Oct 11, 2024 · 4 comments
Closed
Tracked by #737
Labels

Comments

@monicacecilia
Copy link
Contributor

Following the Directors' recommendations, our Monarch Tech Team advanced a proposal to combine all the results tables into a single page, without drop-down menus, when users explore the knowledge graph with the Monarch website. It includes a navigation "column" on the left, allowing users to easily return to any sections.

For an example of the proposed changes, please visit the Monarch development website and navigate to the Gene Page for apolipoprotein E (APOE) here: APOE | Monarch Initiative.

Please provide your feedback on this ticket.

This ticket concerns how results are displayed and how easy it is to navigate through them. We are also working on updating some table headers (see #835 and #837); please feel free to provide additional feedback if desired.

FYI: @kevinschaper 👀 👆🏽

@cmungall
Copy link
Member

I vastly prefer this style of display. This is commonly used for all knowledge bases.

I think there are a few things that could be improved or minor bugs. I will list a few to give a flavor. But to be clear, I think this new change should go ahead, and we can incrementally improve on some aspects.

Minor:

  • If there are exactly 5 associations, it allows me to advance to next to show an empty list in the range "6-5". Off by one error?
  • The ordering of association on the page can be improved. Interactions is not useful and not in Monarch's core area. In contrast, diseases are. Put these before interactions
  • for orthologs there may be a more intuitive column order
  • it may make sense to bundle GO
  • why is external info not along with the other metadata? Some seems duplicative eg. ensembl mappings
  • it's clunky to say "Phenotype to Gene" and confusing since the gene is on the left. If the context/focus is already gene, then just say phenotype
  • there are many cases where you can collapse redundant annotations
  • GO annotations seem to have lost their publications

@damiansm
Copy link

Some quick, general feedback

  • The whole style with less white space is so much better
  • I definitely prefer all the associations being shown like this - advertises what we have and much easier to find
  • Do we really need the association column in every table? I guess you want to keep things generic but to me it does not add any extra useful information, is repetitive, takes up space and is a bit ontology-geeky for some general users
  • Why is taxon empty in so many tables.
  • I don't get the point of the extra info section - just put all that at the top with the other xrefs.
  • Breadcrumbs could be displayed in a more typical format at the top of the page?
  • I would vote for a new colour scheme but sure we have another ticket for that already.

@kevinschaper
Copy link
Member

kevinschaper commented Oct 22, 2024

Style

Layout/Order

Associations

@sagehrke
Copy link
Member

sagehrke commented Nov 1, 2024

All input has been documented in individual tickets. You can see those tickets linked above and in our UI super ticket #737

@sagehrke sagehrke closed this as completed Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

6 participants