-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
phenogrid multi-compare display is out of frame after monarch-app v1.8.0 #887
Comments
I'm running |
The behavior changed with 2c878e8 |
It's caused by removing this specific change: 2c878e8#diff-72efdd36954cb80c05a76e4695b9fe99e3422c23a9fcb57bd2d8d226b49f4bff Removing that class does not set |
My best guess is that I was looking at tables on the node page, but it's very possible that I made an irrelevant change that both broke phenogrid and didn't help the node page tables. |
By the way @dpavam, I notice from the code that generates this phenogrid that you knowingly URL encode labels: https://github.com/mpi2/impc-mousephenotype-web/blob/1c0014040fad666cb35c214eeaa8b4b91ff61f70/components/Gene/HumanDiseases/index.tsx#L74 Can you describe what the issue is if you do not encode them? If they are showing up wrong, that's a bug on our end. |
It was removed in 2c878e8 and broke the display of certain embedded phenogrid widgets (see #887) ### Related issues - Addresses #887 (though keep open until new release is deployed) Co-authored-by: Patrick Golden <[email protected]>
Hi @ptgolden, this is related to #826. The mouse model identifiers (what we pass as For example: if the label is: If we don't encode: the tooltip does not show the characters (and anything in between) but the label at the top is ok: if we encode: the tooltip shows the expected text but the label at the top is not quite right. This was a compromise we chose until the tooltip and the label have the same encoding. |
Ah! Thank you. I will add that that case to our testing and fix next week. |
Thank you very much @ptgolden! Out of curiosity, will it be possible to display certain labels of the phenogrid in bold? Perhaps sending something along the lines of: |
@dpavam this issue is resolved as of the latest release-- can you confirm it's working OK? I'll close this issue if so. (You also should not have to escape any text!)
With the changes in #908, |
Can you tell me the context in which you'd like to have bolded text? |
@ptgolden thanks a lot! We applied these changes to our dev site yesterday and seem to be working fine. I will let you know when we move them to production. The phenogrid currently presents mouse model descriptions on the column labels ( On our side, we can make that distinction clear to the phenogrid by adding a specific character/marker to the labels of each |
@ptgolden this issue is solved. Thank you very much! We noticed a small bug related to #755 after clicking transpose or sort. The tooltips of the labels do not move accordingly. The tooltips on the cells are now ok. See images attached. You can see the issue:
|
The Phenogrid iframe embedded on the IMPC website does not display as expected after monarch-app v1.8.0.
This is evident when a large number of phenotypes (either
subjects
orobjectSets
) are passed to the phenogrid. A good example can be found here. To open the phenogrid navigate to Human diseases caused by Pparg mutations and expand the section for Pparg-Related Familial Partial Lipodystrophy. A screenshot shows the current issue, where the labels of theobjectSets
are not longer visible.The expected behaviour is achieved using the same settings but with monarch-app v1.8.0. Where all the labels are visible and users are able to scroll up or down to see the entire phenogrid. Screenshot of the expected display:
I have attempted manipulating the
height
without success. These are the current settings being used.The text was updated successfully, but these errors were encountered: