Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab history is lost when openng #143

Closed
Matt3o12 opened this issue Apr 19, 2018 · 13 comments
Closed

Tab history is lost when openng #143

Matt3o12 opened this issue Apr 19, 2018 · 13 comments

Comments

@Matt3o12
Copy link

  • Is "Firefox will: Never remember history" in the Firefox Preferences/Options under "Privacy & Security > History" selected? No
  • Are you using Firefox in a Private Window? No
  • Can you see a grayed out but ticked Checkbox with the description "Enable Container Tabs" in the Firefox Preferences/Options under "Tabs"? Yes (ticked)
  • Facebook Container Version: 1.3.1
  • Operating System + Version: MacOS 10.13.4 (also applies to Xubuntu but I'm not sure which version)
  • Firefox Version: 59.0.2
  • Other installed Add-ons + Version + Enabled/Disabled-Status:

Name
Version Enabled ID
1Password Beta 4.7.1.3 true [email protected]
ADB Helper 0.12.0 true [email protected]
Facebook Container 1.3.1 true @contain-facebook
Modify Header Value (HTTP Headers) 0.1.3 true jid0-oEwF5ZcskGhjFv4Kk4lYc@jetpack
QR Code Generator 3.0.0 true jid0-RwTySlpoKU14fw7yw2AflOAihhA@jetpack
uBlock Origin 1.15.24 true [email protected]
Vimium 1.63.3 true {d7742d87-e61d-4b78-b8a1-b469842139fa}
Graphics

Actual/Expected behavior

When clicking any link that refers to facebook/instergram/etc the tab history is lost. It should be possible to open a facebook tab and still be able to go back (and use a normal tab as soon as you go back). If this is technically not possible, there should be an option that always opens facebook links in another tab (if there is an option, I'm sorry I wasn't able to find it). It is not practical to do that manually because:

  1. facebook links are sometimes hidden behind bit.ly, etc and you cannot identify the link as such.
  2. You sometimes just forget that you are about to open a facebook link and finding the previous pages again can be tedious
  3. Normal users can get annoyed at that and simply disable contain-facebook because of that.

Steps to reproduce

  1. Go to some websites which eventually lead to a link to facebook
  2. Click on that facebook link
  3. Try to find the pages you visited in 1) again.
@irgendsontyp
Copy link

Any chances this will be changed in some way? Not being able to navigate back to the previous page after going to facebook is very annoying to me. I'd be very glad if this was possible.

@finnoleary
Copy link

I have exactly the same problem still. Same settings as well.

@maxxcrawford
Copy link
Collaborator

Currently – the only method is undo close tab. This extension by design closes the current tab and reopens the link in a new container.

image

See additional information on Firefox shortcuts.

@maxxcrawford
Copy link
Collaborator

May be a good candidate for #550 feature.

@ygoe
Copy link

ygoe commented Apr 12, 2020

I regularly find Facebook or other sites in Google that will open in a container tab. But I'm used to be able to go back to the search and open another result. This badly fails now with the Facebook container.

Is there at least a way to force-open new containers a additional tab instead of replacing? It's not uncommon that links open in a new tab at their own will, so that would at least be a well-known behaviour and preserve the previous history. The current state is much worse than that.

Since this issue is scheduled for a milestone without time schedule and the previous milestone is already long overdue (is this project even still active?! after all it's a top recommendation from Mozilla), a workaround in a soon release would be much appreciated.

@finnoleary
Copy link

I mean, I get how the code is structured means that it's probably difficult or impossible to do container tabs any other way as-is. But I feel like somewhere in the platonic space there is another implementation that turns the container on when you visit that site, and doesn't communicate prior session information outside the container environment, to the application.

@ygoe
Copy link

ygoe commented May 12, 2020

I assume that this line needs to be removed:

browser.tabs.remove(tab.id);

I cannot test it because Firefox is so badly locked down now that I cannot even patch that extension and verify my fix. It won't load the new extension, even with XPI signing disabled. Firefox is not a developer browser anymore. I wonder how I should develop my own extensions when everything has to be digested (inspected and signed) by the Mozilla Central Authority first?

PS: Maybe the line should be restricted to those cases when the tab's location history is effectively empty. Otherwise I can imagine that newly opened Facebook tabs could remain open empty besides the new container tab.

@maxxcrawford
Copy link
Collaborator

@ygoe You should be able to run the extension locally through web-ext. We also have a development guide in this repo.

@addeps3
Copy link

addeps3 commented May 19, 2020

I would prefer the extension to open contained links in a new tab, instead of closing the previous one, because when I click results after googling them, and the search tab closes, I have repeat the search, or re-open the previously closed tab.
It would be much more convenient to just open a new tab when clicking contained links.
Or let the user select behavior.

@shbach
Copy link

shbach commented May 25, 2020

This looks like a duplicate of #24. Clearly, this is an issue that keeps getting reported for the past two years without a fix.

@addeps3
Copy link

addeps3 commented May 26, 2020

@shbach
I tested again, now that I recieved your notice.
On FF 76.0.1 it is working.

@maxxcrawford
Copy link
Collaborator

Duplicate of #24

@maxxcrawford maxxcrawford marked this as a duplicate of #24 May 26, 2020
@addeps3
Copy link

addeps3 commented May 26, 2020

...And stopped working again.

maxxcrawford added a commit that referenced this issue Jan 27, 2021
…ng the active tab, discarding the history state
maxxcrawford added a commit that referenced this issue May 11, 2022
…ng the active tab, discarding the history state
maxxcrawford added a commit that referenced this issue Jun 8, 2022
…ng the active tab, discarding the history state
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants