-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tab history is lost when openng #143
Comments
Any chances this will be changed in some way? Not being able to navigate back to the previous page after going to facebook is very annoying to me. I'd be very glad if this was possible. |
I have exactly the same problem still. Same settings as well. |
Currently – the only method is |
May be a good candidate for #550 feature. |
I regularly find Facebook or other sites in Google that will open in a container tab. But I'm used to be able to go back to the search and open another result. This badly fails now with the Facebook container. Is there at least a way to force-open new containers a additional tab instead of replacing? It's not uncommon that links open in a new tab at their own will, so that would at least be a well-known behaviour and preserve the previous history. The current state is much worse than that. Since this issue is scheduled for a milestone without time schedule and the previous milestone is already long overdue (is this project even still active?! after all it's a top recommendation from Mozilla), a workaround in a soon release would be much appreciated. |
I mean, I get how the code is structured means that it's probably difficult or impossible to do container tabs any other way as-is. But I feel like somewhere in the platonic space there is another implementation that turns the container on when you visit that site, and doesn't communicate prior session information outside the container environment, to the application. |
I assume that this line needs to be removed: contain-facebook/src/background.js Line 266 in 7bded66
I cannot test it because Firefox is so badly locked down now that I cannot even patch that extension and verify my fix. It won't load the new extension, even with XPI signing disabled. Firefox is not a developer browser anymore. I wonder how I should develop my own extensions when everything has to be digested (inspected and signed) by the Mozilla Central Authority first? PS: Maybe the line should be restricted to those cases when the tab's location history is effectively empty. Otherwise I can imagine that newly opened Facebook tabs could remain open empty besides the new container tab. |
@ygoe You should be able to run the extension locally through web-ext. We also have a development guide in this repo. |
I would prefer the extension to open contained links in a new tab, instead of closing the previous one, because when I click results after googling them, and the search tab closes, I have repeat the search, or re-open the previously closed tab. |
This looks like a duplicate of #24. Clearly, this is an issue that keeps getting reported for the past two years without a fix. |
@shbach |
Duplicate of #24 |
...And stopped working again. |
…ng the active tab, discarding the history state
…ng the active tab, discarding the history state
…ng the active tab, discarding the history state
Name
Version Enabled ID
1Password Beta 4.7.1.3 true [email protected]
ADB Helper 0.12.0 true [email protected]
Facebook Container 1.3.1 true @contain-facebook
Modify Header Value (HTTP Headers) 0.1.3 true jid0-oEwF5ZcskGhjFv4Kk4lYc@jetpack
QR Code Generator 3.0.0 true jid0-RwTySlpoKU14fw7yw2AflOAihhA@jetpack
uBlock Origin 1.15.24 true [email protected]
Vimium 1.63.3 true {d7742d87-e61d-4b78-b8a1-b469842139fa}
Graphics
Actual/Expected behavior
When clicking any link that refers to facebook/instergram/etc the tab history is lost. It should be possible to open a facebook tab and still be able to go back (and use a normal tab as soon as you go back). If this is technically not possible, there should be an option that always opens facebook links in another tab (if there is an option, I'm sorry I wasn't able to find it). It is not practical to do that manually because:
Steps to reproduce
The text was updated successfully, but these errors were encountered: