-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace rouille
with axum
#2234
Comments
Have you considered porting |
Wow, that's great work, respect! I don't have a strong opinion on Warp and Axum as long as all tests pass. I believe that paritytech/cachepot#131 has completed the most challenging part of the migration work. This will significantly simplify our tasks, especially if we decide to use axum in the future. I's happy to review and get it merged if someone port this PR here. I will get it a try first to see how many conflicts there: oh... Auto-merging .github/workflows/ci.yml
CONFLICT (content): Merge conflict in .github/workflows/ci.yml
Auto-merging Cargo.lock
CONFLICT (content): Merge conflict in Cargo.lock
Auto-merging Cargo.toml
... |
Indeed. More merge conflicts than expected.
|
Thanks a lot for picking up this work! |
I'm in the progress with this task. I'm troubleshooting flakiness that I get while testing after merging the changes. |
Since we are heavily using
tokio
andreqwest
, it would be more sensible to use an asynchronous web framework rather than a blocking one.Migrating to
axum
will have the following benefits too:The text was updated successfully, but these errors were encountered: