Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Probe dictionary should not show all probes by default #537

Open
fbertsch opened this issue Apr 19, 2018 · 7 comments
Open

Probe dictionary should not show all probes by default #537

fbertsch opened this issue Apr 19, 2018 · 7 comments

Comments

@fbertsch
Copy link
Contributor

It's a bit annoying to go to the probe-dictionary only to wait a few seconds while everything loads. Instead it should be blank, and searches should show results.

@chutten
Copy link
Contributor

chutten commented Apr 19, 2018

I think we'd get 80% there if we made the loading indicator non-modal.

@Sylvia23
Copy link
Collaborator

@fbertsch I would like to give it a shot. Can I take this up? Thanks!

@fbertsch fbertsch assigned fbertsch and Sylvia23 and unassigned fbertsch Apr 19, 2018
@fbertsch
Copy link
Contributor Author

All yours! @georgf you may have some input on how this should look.

@georgf
Copy link
Contributor

georgf commented Apr 25, 2018

I did not see this issue before, sorry. Now i get a better idea of the goal of #538.
I think the probe dictionary should not default to blank and added detail in #538.

There are at least two use-cases to consider here:
(1) existing users that come in with a concrete search
(2) new users that we want to encourage to explore the data

For (2) this should start off with data to play around with, not empty.

For (1), we can't do actual interaction until the data is loaded, but from this i gather we should improve performance / perceived performance.
I wonder how this should work until we have the data loaded?
Show a non-modal loading indicator in the results area but already allow typing in the search box?

@Insiyaa
Copy link
Collaborator

Insiyaa commented Apr 25, 2018

What if in the while the data is loaded we display the recent additions?

@georgf
Copy link
Contributor

georgf commented Apr 27, 2018

You mean showing only the most recently added probes?

If i understand you right, then this has the same problem. Nearly all the probe data comes from the same large JSON file (this one).

@georgf
Copy link
Contributor

georgf commented Apr 27, 2018

So, one option could be to:

  • Remove the modal loading bar.
  • Put a loading bar in the search results area (while we wait for the probe data).
  • When the loading finished, hide the loading bar.
  • If there is a non-empty search input, show the results.

This mostly works, but has two issues:

  • The version filter dropdown is populated from the all_probes file.
  • How to handle users that arrive through a detailView link (example)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants